Conversation
praetoriansentry
approved these changes
Nov 9, 2024
Collaborator
praetoriansentry
left a comment
praetoriansentry
left a comment
There was a problem hiding this comment.
Looks good to me.
The only minor comment I would have is that adding an additional HTTP server and port might be unnecessary. The pprof endpoints can be handled over port 9711 as well if that's preferable. That being said, a dedicated pprof port is a bit clearer for someone just running docker ps and seeing which ports are mapped.
Collaborator
Author
|
good point, would prefer kurtosis engine to not take up another port if it doesn't need to so I'll remove 6060 |
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Nov 19, 2024
🤖 I have created a release *beep* *boop* --- ## [1.4.2](v1.4.1...1.4.2) (2024-11-10) ### Bug Fixes * don't include component name in release please tags ([#2590](#2590)) ([28582cc](28582cc)) * make releases work again without v in tags ([#2586](#2586)) ([a87f945](a87f945)) * remove closeChannelWhenEmpty busy loop ([#2594](#2594)) ([dbb2193](dbb2193)) * wrong config structure for release please ([#2588](#2588)) ([e7263c3](e7263c3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses #2593 by getting rid of the busy loop entirely. The loop was checking to make sure all values from the channel were read before closing the channel. When following logs, if a stream is cancelled before reading all logs in the channel, it loops infinitely. This changes the consumer to loop until it's read everything from the channel, even after its been closed.
Also, adds a port for pprof to help with profiling in the future.
Is this change user facing?
YES
References
#2593