Conversation
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
tedim52
commented
Feb 7, 2024
...ngine-lib/lib/backend_impls/docker/docker_kurtosis_backend/engine_functions/create_engine.go
Show resolved
Hide resolved
tedim52
commented
Feb 7, 2024
tedim52
commented
Feb 7, 2024
container-engine-lib/lib/backend_impls/docker/docker_kurtosis_backend/consts/consts.go
Show resolved
Hide resolved
laurentluce
approved these changes
Feb 7, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 8, 2024
🤖 I have created a release *beep* *boop* --- ## [0.86.16](0.86.15...0.86.16) (2024-02-07) ### Features * kurtosis github login ([#2113](#2113)) ([2f0d638](2f0d638)) ### Bug Fixes * Remove Derek and Karla as default assignees for docs issues ([#2129](#2129)) ([2f1eecc](2f1eecc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This change enables GitHub users over Docker to authorize with Kurtosis CLI so that Kurtosis can perform git operations such as cloning packages in private repositories. This primarily enables the use of private GitHub locators for package runs,
import_module, andupload_files.This is accomplished via an OAuth flow where
kurtosis github logindirects the user to authorize Kurtosis CLI to take actions on their behalf. A token is retrieved upon success and is used by Kurtosis for subsequent git operations. Kurtosis attempts to store the token in secure system storage, but if not found, the token is stored in a plain text file atkurtosis config path.Github commands added:
kurtosis github loginkurtosis github logoutkurtosis github tokenkurtosis github statusFlags added (these override existing GitHub login for one off authorization use cases):
kurtosis engine start --github-auth-token=< token.txtkurtosis engine restart --github-auth-token=< token.txtIs this change user facing?
YES
References:
#2020