Skip to content

remove redundant check #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kunwardeep merged 4 commits into from
Oct 14, 2025
Merged

remove redundant check #55

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7730540
remove redundant check
kunwardeep Oct 14, 2025
bfe8df7
Merge branch 'main' into fix-false-positive-remove-redundant-check
kunwardeep Oct 14, 2025
8582a41
updated comments
kunwardeep Oct 14, 2025
bf759bb
Merge branch 'fix-false-positive-remove-redundant-check' of github.co…
kunwardeep Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions pkg/paralleltest/paralleltest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,10 +264,6 @@ func (a *parallelAnalyzer) checkBuilderFunctionForParallel(pass *analysis.Pass,
// Found the builder function, analyze it and return immediately
hasParallel := false
ast.Inspect(funcDecl, func(n ast.Node) bool {
if hasParallel {
return false
}

// Look for return statements
returnStmt, ok := n.(*ast.ReturnStmt)
if !ok || len(returnStmt.Results) == 0 {
Expand Down Expand Up @@ -296,14 +292,15 @@ func (a *parallelAnalyzer) checkBuilderFunctionForParallel(pass *analysis.Pass,
return true
})

// Exit immediately if we found t.Parallel()
// Exit inspection immediately if we found t.Parallel()
if hasParallel {
return false
}
}
}
}
return !hasParallel // Stop inspection if we found t.Parallel()
// Continue to next return statement if t.Parallel() not found yet
return true
})

// Return immediately after processing the matching function
Expand Down