Skip to content

tests: simplify the set up #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kunwardeep merged 2 commits into from
Mar 28, 2025
Merged

tests: simplify the set up #48

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9072e87
tests: simplify the set up
ldez Mar 27, 2025
49fd111
Merge branch 'main' into fix/simplify-tests-setup
kunwardeep Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 3 additions & 23 deletions pkg/paralleltest/paralleltest_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
package paralleltest

import (
"os"
"path/filepath"
"testing"

"golang.org/x/tools/go/analysis/analysistest"
Expand All @@ -11,41 +9,23 @@ import (
func TestMissing(t *testing.T) {
t.Parallel()

wd, err := os.Getwd()
if err != nil {
t.Fatalf("Failed to get wd: %s", err)
}

testdata := filepath.Join(filepath.Dir(wd), "paralleltest", "testdata")
analysistest.Run(t, testdata, NewAnalyzer(), "t")
analysistest.Run(t, analysistest.TestData(), NewAnalyzer(), "t")
}

func TestIgnoreMissingOption(t *testing.T) {
t.Parallel()

wd, err := os.Getwd()
if err != nil {
t.Fatalf("Failed to get wd: %s", err)
}

a := newParallelAnalyzer()
a.ignoreMissing = true

testdata := filepath.Join(filepath.Dir(wd), "paralleltest", "testdata")
analysistest.Run(t, testdata, a.analyzer, "i")
analysistest.Run(t, analysistest.TestData(), a.analyzer, "i")
}

func TestIgnoreMissingSubtestsOption(t *testing.T) {
t.Parallel()

wd, err := os.Getwd()
if err != nil {
t.Fatalf("Failed to get wd: %s", err)
}

a := newParallelAnalyzer()
a.ignoreMissingSubtests = true

testdata := filepath.Join(filepath.Dir(wd), "paralleltest", "testdata")
analysistest.Run(t, testdata, a.analyzer, "ignoremissingsubtests")
analysistest.Run(t, analysistest.TestData(), a.analyzer, "ignoremissingsubtests")
}