Skip to content

Conversation

@ldez
Copy link
Contributor

@ldez ldez commented Mar 27, 2025

No description provided.

@ldez
Copy link
Contributor Author

ldez commented Mar 27, 2025

I will fix the configuration

@kunwardeep
Copy link
Owner

Hey @ldez thanks for cleaning this up. However i am getting this error locally when running your brnach with make install_devtools

make install_devtools
go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@latest
go: github.com/golangci/golangci-lint/v2/cmd/golangci-lint@latest: cannot query module due to -mod=vendor
make: *** [install_devtools] Error 1

@ldez
Copy link
Contributor Author

ldez commented Mar 27, 2025

IMHO, vendoring is not useful. Why are you vendoring the dependencies?

@ldez
Copy link
Contributor Author

ldez commented Mar 27, 2025

The checksum DB and the lock are here to protect you against a checksum mismatch of the dependencies.

@kunwardeep
Copy link
Owner

IMHO, vendoring is not useful. Why are you vendoring the dependencies?

No particular reason—it's just how I set it up five years ago. We can remove it if it’s no longer needed. Would you like to handle that as part of this PR?

I’m trying to clean things up since I finally have some time. Otherwise, I’ve barely had a chance to look at this. I really appreciate your help!

@ldez ldez changed the title chore: update workflow chore: cleanup Mar 27, 2025
@kunwardeep kunwardeep merged commit 2818d51 into kunwardeep:main Mar 27, 2025
2 checks passed
@ldez ldez deleted the fix/workflow branch March 27, 2025 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants