-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes kunkunsh/kunkun#104 #105
Conversation
I didn't understand this PR. You disabled decorations and made the window transparent. |
1a6a8e1 |
This reverts commit 1a6a8e1.
From what I understand, disabling decorations causes the window to no longer behave or identify as a regular macOS window (which aerospace uses to tile windows). Similar behavior can be seen in recent developments like Ghostty (it is not a one-to-one reproduction of this behavior, but is similar). The workaround that is possible from the end-user's side is to add a window rule in aerospace's config to explicitly float it (not sure if this is a good idea for UX though since launchers are expected to float out of the box) |
Found an issue tauri-apps/tauri#2801 I have also seen discussion saying a regular window needs to be converted into a nspanel Maybe this will be useful https://github.com/ahkohd/tauri-nspanel |
Yeah, it needs to behave as a native component to be truly seamless and not result in cascading changes. I do however have a working version of this behavior that works exactly as intended (see below image). The key difference is that, the body does not have any styles applied and i have a wrapper component (within the body) that applies the required rounded corners and background color. Code for this is available at https://github.com/alpha-og/fin |
https://github.com/srsholmes/yal/blob/2a689b7c076a75584fdb58ab46c96aaa87768191/apps/yal/src-tauri/tauri.conf.json#L151 |
This PR #129 may solve the aerospace error by setting mac window's activation policy. app.set_activation_policy(ActivationPolicy::Accessory); I tried it with aerospace, it isn't affected by aerospace. The PR still has some cross-platform compatibility bugs. |
Yeah, setting activation policy might be a way to achieve the NSPanel like behavior atleast partially and also remove the dock icon |
Fixes issue #104 and floating behavior works as expected after tweaks to the window configuration in

tauri.conf.json
and updated client body transparency with some caveatsCaveats