fix(security): address first-pass CodeQL alerts#1114
Merged
Conversation
Owner
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
12 tasks
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: da8ef76ba8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
kunickiaj
changed the base branch from
05-21-chore_deps_patch_protobufjs_runtime_advisories
to
graphite-base/1114
kunickiaj
force-pushed
the
graphite-base/1114
branch
from
f524662 to
b9ee7b0
Compare
kunickiaj
force-pushed
the
05-21-fix_codeql_security_alerts_first_pass
branch
from
da8ef76 to
7ebb359
Compare
kunickiaj
force-pushed
the
05-21-fix_codeql_security_alerts_first_pass
branch
from
7ebb359 to
2cf6c19
Compare
kunickiaj
force-pushed
the
05-21-fix_codeql_security_alerts_first_pass
branch
from
2cf6c19 to
a9beb68
Compare
Owner
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses the first pass of GitHub CodeQL/code scanning alerts on top of the dependency remediation PR. Changes include:
contents: readworkflow permissions for CI.execFileand document the remaining no-shell safety boundary.stats --jsonclear-text logging alert as intentional CLI stdout, not application logging.Type of Change
Testing
pnpm run tsc,pnpm run lint,pnpm run test)Validation run:
pnpm run lintpnpm run checkChecklist
pnpm run lintpasses for touched files)Compatibility note:
claude_commandexecutable validation now allows safe PATH command names and absolute paths, but rejects relative executable paths containing/such as./wrapper.