chore(core): log replication-op emit failures in updateMemoryVisibility#1108
Merged
Conversation
updateMemoryVisibility wraps recordReplicationOp in a silent try/catch with "Non-fatal" as the only comment. The intent (don't fail the visibility write on a replication hiccup) is correct, but the silence hides whatever actually broke the replication path — peers stop learning about the change and no signal reaches the operator. Replace the swallow with a structured console.warn using the existing [codemem] prefix convention (matches db.ts, observer-client.ts, sync-discovery.ts, etc.). Includes the memory id and the error message so a failure leaves a forensic trail without crashing the caller. Behavior is otherwise unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Owner
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
updateMemoryVisibilitywrapsrecordReplicationOpin a silenttry/catchwith\"Non-fatal\"as the only comment. The intent (don't fail the visibility write on a replication hiccup) is correct, but the silence hides whatever actually broke the replication path — peers stop learning about the change and no signal reaches the operator.Replace the swallow with a structured
console.warnusing the existing[codemem]prefix convention (matchesdb.ts,observer-client.ts,sync-discovery.ts, etc.). Includes the memory id and the error message so a failure leaves a forensic trail without crashing the caller. Behavior is otherwise unchanged.This is a standalone re-do of the visibility-side change from the now-closed sticky-rules feature stack; the rest of that feature was scrapped.
Type of Change
Testing
pnpm run tsc,pnpm run lint,pnpm run test) — workspace 1927/1927[codemem]log linesChecklist
pnpm run lintpasses for touched files)