Skip to content

feat(ui): add Sharing domain settings panel#1046

Merged
kunickiaj merged 1 commit into
mainfrom
05-05-feat_ui_add_sharing_domain_settings_panel
May 6, 2026
Merged

feat(ui): add Sharing domain settings panel#1046
kunickiaj merged 1 commit into
mainfrom
05-05-feat_ui_add_sharing_domain_settings_panel

Conversation

@kunickiaj
Copy link
Copy Markdown
Owner

@kunickiaj kunickiaj commented May 6, 2026

Description

Adds the Settings UI surface for assigning known projects to Sharing domains. The panel shows Local-only fallback for unmapped/unknown projects, saves explicit project mappings through the viewer API, and avoids presenting coordinator/group membership as data access.

Stack slice: UI for codemem-ov4g.6.1. Depends on #1044 and #1045.

Type of Change

  • 🚀 Feature (new functionality)
  • 🐛 Bug fix (fixes an issue)
  • 📚 Documentation (docs-only change)
  • 🔧 Maintenance (refactor, chore, CI, etc.)
  • 🧪 Testing (test-only changes)

Testing

  • Relevant checks pass locally (pnpm run tsc, pnpm run lint, pnpm run test)
  • Added/updated tests for changes
  • Manually verified changes work as expected

Validation run:

  • pnpm exec vitest run packages/ui/src/tabs/settings/components/SharingDomainsPanel.test.tsx
  • pnpm --filter @codemem/ui build
  • pnpm run tsc
  • touched-file Biome check

Checklist

  • Code follows project style (pnpm run lint passes for touched files)
  • Self-review completed
  • Documentation updated (if needed)
  • No new warnings introduced

Copy link
Copy Markdown
Owner Author

kunickiaj commented May 6, 2026

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: aeca23344b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/ui/src/tabs/settings/components/SharingDomainsPanel.tsx
@kunickiaj kunickiaj force-pushed the 05-05-feat_ui_add_sharing_domain_settings_panel branch from aeca233 to 82e4382 Compare May 6, 2026 05:27
@kunickiaj kunickiaj force-pushed the 05-05-feat_viewer_expose_sharing_domain_settings_api branch from a5fc1be to 5bb6178 Compare May 6, 2026 05:27
Copy link
Copy Markdown
Owner Author

kunickiaj commented May 6, 2026

Merge activity

  • May 6, 1:52 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • May 6, 1:57 PM UTC: Graphite rebased this pull request as part of a merge.
  • May 6, 1:58 PM UTC: @kunickiaj merged this pull request with Graphite.

@kunickiaj kunickiaj changed the base branch from 05-05-feat_viewer_expose_sharing_domain_settings_api to graphite-base/1046 May 6, 2026 13:53
@kunickiaj kunickiaj changed the base branch from graphite-base/1046 to main May 6, 2026 13:55
@kunickiaj kunickiaj force-pushed the 05-05-feat_ui_add_sharing_domain_settings_panel branch from 82e4382 to 191a279 Compare May 6, 2026 13:56
@kunickiaj kunickiaj merged commit fdb6183 into main May 6, 2026
8 checks passed
@kunickiaj kunickiaj deleted the 05-05-feat_ui_add_sharing_domain_settings_panel branch May 6, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant