fix(core): enforce scope visibility in memory retrieval#1031
Merged
kunickiaj merged 1 commit intoMay 5, 2026
Merged
Conversation
Owner
Author
This was referenced May 5, 2026
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4d95120c9b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
kunickiaj
force-pushed
the
05-04-fix_core_enforce_scope_visibility_in_memory_retrieval
branch
from
4d95120 to
6d49107
Compare
Owner
Author
Merge activity
|
Apply local scope authorization centrally across core store/search read paths so caller-provided scope filters can only narrow visible data. This prevents unauthorized scope rows from leaking through direct reads, ranking, timeline windows, or explain diagnostics.
kunickiaj
force-pushed
the
05-04-fix_core_enforce_scope_visibility_in_memory_retrieval
branch
from
6d49107 to
9b34cd1
Compare
kunickiaj
deleted the
05-04-fix_core_enforce_scope_visibility_in_memory_retrieval
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a central scope-visibility gate so default
MemoryStoreand search paths cannot return memories outside the device's authorized sharing domains. Local-default and legacy null/blank scope rows remain visible; coordinator-scope rows require an active local membership. Explicit scope filters (scope_id,include_scope_ids,exclude_scope_ids) intersect with the gate, never widen it.This is the foundation for the OV4G.5 retrieval-hardening stack (codemem-ov4g.5.2).
Type of Change
Testing
Coverage: store get/recent/recentByKinds/search/timeline/explain, plus a regression for legacy null/blank scope rows.
Checklist