feat(harness): add verified Cursor worker adapter - #787
Closed
Amplify-Logic wants to merge 2 commits into
Closed
Amplify-Logic wants to merge 2 commits into
Amplify-Logic wants to merge 2 commits into
Conversation
…4.5)
Adds `cursor` (Cursor CLI `agent`) as a verified worker-only adapter. Primary support was not verified and is not claimed.
Also fixes two shared composer-monitoring defects discovered during verification: reverse-video idle cells surviving ghost-strip (false pending), and tmux `#{cursor_y}` missing the composer (false empty). Detection tests `CURSOR_AGENT` before `CLAUDECODE` because cursor does not clear an inherited Claude marker.
Keep startup dispatch validation and secondmate liveness aligned with the verified worker adapter set, including Cursor's model-suffixed effort range.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Owner
|
Speaking as Kun's firstmate: closing this as stale. It has been waiting on a contributor update for 14+ days with no author push or comment. Reopen if you want to pick it back up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
cursor(Cursor CLIagent) as a verified worker-only adapter. Primary-orchestrator support was not verified and is not claimed.Verification also found two shared composer-monitoring defects that would have made the adapter unsafe; both are fixed in the shared owners:
pending, deferring away-mode escalations forever. The idle regex is now also matched against the plain (unstyled) row.#{cursor_y}points at cursor's bottom status area, not the composer. Reading that row found an empty status line while real unsubmitted text was present - the dangerous false-empty direction for the away-mode injector. The tmux path now locates the composer structurally (scoped to panes positively identified as cursor).Other integration points:
--yolo,--workspacepinned to the task worktree, deliberately no-wso cursor never allocates a second worktree.cursor/hooks.jsonstophookcursor_model_with_effort);xhigh/maxcap athighCURSOR_AGENT=1detection is tested beforeCLAUDECODEbecause cursor does not clear an inherited Claude markerctrl+c to stop(not the spinner verb, which flips mid-turn)Evidence and limitations:
docs/cursor-harness.md. Backends: tmux verified; herdr composer-safe by construction with liveness unverified; zellij/orca/cmux not exercised with cursor.Test plan
bin/fm-lint.shtests/fm-cursor-adapter.test.sh(including under ambientCURSOR_AGENT=1)tests/fm-bootstrap.test.shtests/fm-secondmate-liveness.test.sh