Conversation
This was referenced Aug 9, 2026
This was referenced Aug 9, 2026
This was referenced Aug 10, 2026
This was referenced Aug 11, 2026
This was referenced Aug 11, 2026
This was referenced Aug 12, 2026
|
No description provided. |
iscooter
added a commit
to iscooter/firstmate
that referenced
this pull request
Sep 21, 2026
Two defects in the test: the always-mode bypass was never triggered (a ruleset edit is not a PR event), and the window that was exercised had a behind-branch blocker under strict required status checks. Corrects the claim that GitHub merges as itself rather than as the App — merged_by on demo kunchenguid#63/kunchenguid#62 is bankrate-bender[bot]. Demo repo fully restored and verified. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
pr-readinessskill and wires firstmate's PR workflow to use it before public PR actions.The skill is meant to catch the failure mode where a branch or PR is presented to a maintainer while it is stale, conflicting, missing validation evidence, too broad, or still written with private local context that does not belong in public PR text.
Why
Fork/replacement PR work often needs one last maintainer-facing audit after local validation: refresh the actual base repo/ref, check mergeability, compare against current base, look for overlap with recently merged work, verify public text, and stop before asking anyone to review or merge if the PR is not ready.
Changes
.agents/skills/pr-readiness/SKILL.md.origin/main.Validation
quick_validate.py .agents/skills/pr-readiness- passedno-mistakesrun01KVWBJ8EG90PBFPEBP33JW3V8-checks-passedThe no-mistakes review fixed three issues before final validation:
main.origin.GitHub currently reports no status checks configured for this fork PR, so the validation evidence is the local/no-mistakes run above.