Repository navigation
feat: support named crew and base branches - #5616
lakshyads05 wants to merge 21 commits into
Conversation
|
@kunchenguid please approve the workflows |
9182114 to
ba8e0dd
Compare
|
|
Speaking as Kun's firstmate: HEAD Contract-class: opt-in (own tip-vs-main). VISION.md (each rule)
Fork CI: approved this tip after diff review — CI |
|
@kunchenguid please review and approve the workflows |
|
@kunchenguid please review and approve the workflows |
|
why are the workflows not yet triggered? @kunchenguid Please fasttrack this as I have been waiting for this work to land since more than a month now - and this is my third PR as the old ones got too old with lots of commits just to resolve merge conflicts. |
Bare repositories and office work that ships against a named feature branch need a full crew branch and an integration branch through launch, PR target, review, and landing.
…ests/fm-named-branches.test.sh. Targeted test, bash syntax check, and diff validation pass; shellcheck reports only the existing SC1091 info for tests/lib.sh
bee4529 to
910326a
Compare
|
Rebased onto current What this rebased branch contains (
The remaining suite failures in this environment (herdr/orca/zellij/backend e2e, backlog-atomicity, teardown-with-backlog, bearings-board) reproduce identically on pristine Note: neither side of this PR grants push access to curl -sL https://gist.githubusercontent.com/wesleymatosdev/baaf78443935927e9a138f077b534095/raw | git am
git push -f origin <this PR's head branch>Closes #1887's ask: named crew and base branches, reconciled with everything |
Intent
PR #4071 is stale; discard it. Evaluate current upstream main for support for custom crew and base branches, needed for bare repositories and office work that ships against a named feature branch. If upstream still lacks that support, create a fresh PR with the minimum surgical changes required for custom named branches.
go with your recommended option
ask the worker to refresh the PR by rebasing.
yes i authorize
there are failing CI on #5616 fix this
bring the PR 5616 upto date with upstream main
Preserve local tip 9182114b under a separate reference and adopt published head bee45299 locally. Proceed with the guarded reconciliation and refresh #5616 against upstream main.
The pull request is the minimum surgical support for selecting a named crew branch and a named base branch at task launch, pull-request target, and landing, including bare repositories and office work that ships against a named feature branch. The chosen option removes the new generic Done-title suffix parsing rather than introducing a persisted completion-note marker. Keep ordinary titles intact. Named local-branch landing details may be narrower in the fleet view. Keep the focused test correction that pins an isolated claude crew-harness so a missing named base is reported as missing rather than as an unknown harness. Refresh that existing pull request by rebasing onto current upstream main and keep the same pull request.
What Changed
Risk Assessment
Testing
Ran the three focused behavioral suites and drove all derived branch, landing, bare-repository, fleet-note, replay, and Herdr guard scenarios against real scripts with disposable labs. No UI surface was involved, so no screenshot was applicable. Worktree remained clean.
Evidence: Named brief contract
Evidence: Herdr launch guard
Evidence: Named review and landing
Evidence: Bare repository landing
Evidence: Fleet note projection
Evidence: Session-start replay
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ No issues found.
🔧 **Test** - 1 issue found → no changes applied ✅
tests/fm-named-branches.test.shfocused named-branch casestests/fm-fleet-snapshot-view.test.shtest_recovery_preserves_a_named_local_landing_notetests/fm-backend-autodetect-smoke.test.shwith disposable FM_HOME🔧 No changes applied.
✅ Re-checked - no issues remain.
bash tests/fm-named-branches.test.shbash tests/fm-fleet-snapshot-view.test.shbash tests/fm-backlog-atomicity.test.shDisposable live brief, promotion, review, local landing, bare-repository, fleet projection, and session-start replay checksDisposable named Herdr lab launch-preflight check✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.