Conversation
…ation in script header
…ate-20260919 feat: gate fresh CLAUDE.md pointer creation on Claude Code version >= 2.1.277
…tage 2) (#2) * feat(bin): complete stage 2 CLAUDE.md pointer removal * no-mistakes(review): Restore column-0 heredoc regression fixture with generic content * no-mistakes(review): Remove stale CLAUDE.md pointer claim from updatefirstmate skill --------- Co-authored-by: irene <irene@ireneui-MacBookPro.local>
Prior commits on this branch regressed past stage2, restoring the unconditional CLAUDE.md pointer-write logic stage2 removed. Reset to fork/main (stage2's merged head) and redo stage3 correctly: delete the now-dead fm_version_at_least/claude_supports_native_agents_md functions and their header-comment reference, and drop the now-vestigial with_mock_claude/with_no_claude test helpers (the script no longer reads claude --version at all). Co-authored-by: irene <irene@ireneui-MacBookPro.local>
…eering skills (#4) * feat: add lazy specialist tool routing Expose ECC, paperthin, and ultrawork as captain-approved specialist paths while keeping Firstmate intake and lifecycle authority. Load only the selected skill or mode and keep ECC hooks, MCP, and legacy sync opt-in. * docs(agents): recover firstmate-layout and task-steering skills These two skills existed only on an orphaned local branch, never pushed. firstmate-layout is re-extracted from AGENTS.md section 2's current (much larger) layout tree rather than reusing the stale 2026-09-14 snapshot. task-steering's underlying AGENTS.md paragraph was byte-identical to the 2026-09-14 extraction, so it is reused as-is. Both get a one-line trigger in section 13 and a documentation-audiences.json entry, matching how specialist-tools (recovered earlier on this branch) is registered. --------- Co-authored-by: irene <irene@ireneui-MacBookPro.local>
Co-authored-by: irene <irene@ireneui-MacBookPro.local>
.treehouse/ holds only runtime pool bookkeeping (treehouse-state.json, treehouse-state.lock), never captain work, but its absence from .gitignore makes it show up as an untracked dirty-tree blocker for bin/fm-update.sh's self-update fast-forward check. Co-authored-by: irene <irene@ireneui-MacBookPro.local>
Verified against no-mistakes v1.79.0's own e2e tests and upstream PR kunchenguid#1120: jev.review_assist is global-only and has no effect when set in a repo's tracked .no-mistakes.yaml. Revert that no-op change and document the real activation path, data sent, and data-boundary guidance instead.
Author
|
Closing: opened against the wrong base by mistake, not an intended contribution to this repo. Re-targeting to the correct fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Document how to correctly enable no-mistakes v1.79.0+'s opt-in jev.review_assist advisory pre-brief for the review step. Investigation during this task discovered jev.review_assist is global-only and has no effect when set in a repo's tracked .no-mistakes.yaml (confirmed against no-mistakes' own e2e tests and upstream PR #1120), so the originally planned repo-config change is a no-op and has been reverted. Instead this documents in docs/configuration.md: the real per-operator activation path (~/.no-mistakes/config.yaml plus TYPESAFE_API_KEY in the daemon environment), exactly what data is sent (diff of reviewable files plus up to 40 candidate file paths, paths only, never content, never project name/PR body/brief text), why this repo's gitignored/captain-private paths (.env, data/, state/, config/, projects/, .no-mistakes/) can never reach Jev (they are untracked and never appear in a git diff), and that the review step log is the audit trail for whether a pre-brief was requested/used. The ordinary cold complete review remains authoritative; Jev is advisory only and never gates delivery. This change must never be delivered to kunchenguid/firstmate upstream, only to the Ivory2024/firstmate fork.
What Changed
CLAUDE.mdpointer creation; and document global-only Jev review assist activation, data boundaries, fallbacks, and audit logs.Risk Assessment
Testing
Inspected the target documentation diff and confirmed the requested Jev consumer, credentials, payload boundary, and audit trail are external to this repository. No live product scenario, UI artifact, or external daemon evidence could be produced in this assigned phase.
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
.agents/skills/firstmate-layout/SKILL.md- branch carries 10 commit(s) that exist on your local main branch but were never pushed to origin/main; these may be unintended bundled work (proposed PR changes 35 file(s)):Confirm these commits belong in this PR before approving, or manually separate the intended work onto origin/main before gating.
✅ No issues found.
docs/configuration.md:233- No live-validatable surface exists in this worktree for the documented Jev behavior. Validation requires no-mistakes v1.79.0+ with its daemon, permitted TYPESAFE_API_KEY, and review-step audit logs.git diff 1bb72cc5f88014c86e3d03244efa0bb26c22d001 0cec3eefe515a5396c42e1cf39a105d9a9179c93 -- docs/configuration.mdrg -n -C 3 "jev|review_assist|TYPESAFE_API_KEY|candidate file|audit trail" docs/configuration.md .no-mistakes.yaml✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.