Conversation
The OMP Calm extension lived untracked at .omp/extensions/fm-calm-omp.ts, so it loaded only in sessions whose cwd was the firstmate home. Move it to extensions/fm-calm-omp/ as an omp plugin package and add bin/fm-omp-calm-install.sh, which links it into OMP's user plugin scope so /calm-omp and the working boat load in every omp session. The package stays outside .omp/extensions/ because OMP de-duplicates extension entries by absolute path, not realpath: a project-local copy plus a global link would load twice in home sessions. The installer retires the legacy copy, removing an identical file and renaming a divergent one to .bak.
… regression tests
mdc2122
force-pushed
the
fm/calm-omp-global-10
branch
from
September 16, 2026 04:23
e71e7e0 to
0ca583e
Compare
Author
|
Closing in favor of a single clean Calm-for-omp PR cut from current main, if we re-propose it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Make the calm-omp extension work globally for all omp sessions, not just firstmate sessions.
What changed
extensions/fm-calm-omp/— the OMP Calm extension (/calm-omp+ the shared working-ship boat) as an OMP plugin package (package.jsonomp.extensionsentry). It lives outside.omp/extensions/on purpose: OMP de-duplicates extension entries by absolute path rather than realpath, so a project-local copy plus a global link would double-load in sessions running inside a firstmate checkout.bin/fm-omp-calm-install.sh— links the package into OMP's user plugin scope viaomp plugin link(~/.omp/plugins/node_modules/fm-calm-omp). Idempotent; retires the legacy project-local.omp/extensions/fm-calm-omp.ts(identical → removed, divergent →.bak, aborts on failure); warns when linked from a git worktree.tests/fm-omp-calm-install.test.sh— sandboxed-HOME behavioral coverage: link, idempotent reinstall, identical/divergent legacy handling, failed-retirement abort, manifest resolution.docs/calm.mdgains the OMP section (mechanism, install, unload viaomp plugin disable— omp 18.2.0'splugin uninstallleaves the symlink and the extension keeps loading),docs/calm-mode-feasibility.mdgains the dated verification record,README.mdandAGENTS.mdget one-line pointers.Verified (OMP 18.2.0)
bin/fm-omp-calm-install.shlinks the package;omp plugin list/doctorreportfm-calm-omphealthy.omp -p "/calm-omp"in a directory outside any firstmate checkout executes the registered command locally with no model call; an unknown command in the same session reaches the model.tests/fm-omp-calm-install.test.shgreen; shellcheck clean;fm-doc-audience-check.shok./calm-ompagainst the real OMP CLI; the interactive TUI toggle/boat path is not exercised headless (accepted at the test gate).