fix: remind supervisors to refresh backlog after teardown - #32
Merged
Merged
Conversation
vipentti
pushed a commit
to vipentti/firstmate
that referenced
this pull request
Aug 5, 2026
…d#32) * remind supervisor to refresh backlog * no-mistakes(document): Sync teardown backlog docs
This was referenced Aug 7, 2026
Closed
Closed
This was referenced Aug 11, 2026
Independent review of head
|
iscooter
added a commit
to iscooter/firstmate
that referenced
this pull request
Sep 21, 2026
…gates Fourteen tasks, TDD throughout. Task 0 captures the real PRs kunchenguid#27, kunchenguid#32 and kunchenguid#37 as fixtures first, so every gate is written against genuine GitHub payloads rather than imagined ones — those three give a full pass, a classification rejection, and a non-bot rejection. Task 1 proves the deploy gate by breaking the rules file on purpose and watching the build fail, rather than asserting it works. Glob matching gets its own task: only three pattern forms are used, so a dependency is not worth it, but a subtly wrong inlined matcher fails open on exactly the path rules that matter. Rendering is split from the gate logic because PLAT-1190's readability criterion is a human judgement and deserves its own review surface — Task 8 ends by printing all three rationales to read as a stranger. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
iscooter
added a commit
to iscooter/firstmate
that referenced
this pull request
Sep 21, 2026
Six tasks, one per fix plus a regression pin and QA confirmation. Written against v1.5.0's actual code - the exact line being replaced in each of the three functions is quoted, so the implementer is editing what is there rather than what a spec imagined. The load-bearing test is the conclusion table: all eight of GitHub's check conclusions asserted into exactly one bucket, so a future added value surfaces as a failure rather than silently grading low. Task 5 pins PR kunchenguid#27 and kunchenguid#32's verdicts explicitly. Every fix here makes the service stricter, and a stricter service that flips the one pull request demonstrating a pass has broken something - the plan says to treat that as the fix being wrong, not the fixture. Task 6 Step 3 warns that the risk grade may legitimately move if a scanner came back cancelled this run. That is the A1 fix working, and without the warning it reads as a regression. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
NewAiCoder
added a commit
to NewAiCoder/firstmate
that referenced
this pull request
Sep 26, 2026
…tream-4 feat(bin): merge upstream firstmate into fork main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Add a plain backlog-refresh reminder to firstmate so queued-item readiness stops going stale. The requested scope is intentionally minimal: after successful fm-teardown.sh completion, print a plain stdout reminder telling the supervisor to update data/backlog.md, move the finished id to Done, keep Done to the 10 most recent, re-scan Queued for items unblocked by the finished id or now time-due, and dispatch ready work. Also tighten one AGENTS.md backlog/supervision line to explicitly include time/date-gated queued items whose date has arrived. Do not add grep or auto-scan logic, structured ready-when or blocked-by machine fields, cron jobs, or new scripts.
What Changed
bin/fm-teardown.shto print a post-teardown reminder to refreshdata/backlog.md, prune Done entries, re-scan queued work, and dispatch anything ready.AGENTS.mdto call out time/date-gated queued items whose date has arrived.Risk Assessment
✅ Low: Captain, the change is a narrow reminder/documentation update that runs only after the existing teardown path succeeds and does not alter teardown safety logic.
Testing
Captain, I inspected the intent, ran the existing shell behavior tests, then exercised the successful
fm-teardown.shpath with reviewer-visible stdout evidence; stderr was empty, transient worktree fixtures were removed, and the working tree was clean afterward.Evidence: fm-teardown reminder transcript
$ bin/fm-teardown.sh test-backlog-r3 teardown test-backlog-r3 complete ... 🌱 Backlog: test-backlog-r3 just finished. Update data/backlog.md - move test-backlog-r3 to Done (keep Done to the 10 most recent), then re-scan Queued for items now unblocked ... or now time-due, and dispatch what's ready.Evidence: AGENTS backlog instruction snippet
AGENTS.md line 489: Re-evaluate Queued on every teardown and every heartbeat: anything whose blocker is gone gets dispatched, and time/date-gated items whose date has arrived get dispatched too.Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
tests/fm-wake-queue.test.shCreated a temporary scout-style teardown fixture fortest-backlog-r3, ranbin/fm-teardown.sh test-backlog-r3with a faketreehouse return --forceonPATH, captured stdout/stderr, and grepped stdout for the completion line plus the Done pruning,blocked-by, time-due, and dispatch reminder text.nl -ba AGENTS.md | sed -n '473,491p' > /var/folders/5x/4nqprlbx0518k3ybcb1sz6gr0000gn/T/no-mistakes-evidence/01KVNPEVJAYB1NBBC5A3KT98YG/agents-backlog-instruction.txtplus a targetedgrep -Ffor the time/date-gated queued-item instruction.✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.