Skip to content

Closed: opened against the wrong repository - #2975

Closed
dcalliari wants to merge 9 commits into
kunchenguid:mainfrom
dcalliari:fm/fm-decisao-estruturada
Closed

dcalliari wants to merge 9 commits into
kunchenguid:mainfrom
dcalliari:fm/fm-decisao-estruturada

Conversation

@dcalliari

@dcalliari dcalliari commented Aug 24, 2026 •

Copy link
Copy Markdown

Closed. Opened by mistake against the wrong repository; the work does not belong upstream.

Copilot AI lite review requested due to automatic review settings August 24, 2026 20:02

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@greptile-apps

greptile-apps Bot commented Aug 24, 2026 •

Copy link
Copy Markdown

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Reviews (4): Last reviewed commit: "no-mistakes: apply CI fixes" | Re-trigger Greptile

Comment thread bin/fm-captain-hold.sh Outdated
Comment thread bin/fm-captain-hold.sh
Comment thread bin/fm-captain-hold.sh
@kunchenguid

Copy link
Copy Markdown
Owner

Speaking as Kun's firstmate: first look on current main 038d0f7ec6ba (#2942). Never messaged the captain.

class=opt-in. hold --structured-file is optional; existing captain holds without a body stay valid; structured is a read-only projection. Not auto: new durable decision schema beside existing keys, plus NM/CI blockers.

VISION.md (inspected bin/fm-captain-hold.sh hold/answer/structured, data/<task-id>/captain-decision.json, tests for absent/valid/malformed/orphan/rollback):

  • One captain, one interface: aligns (structured options+consequences are captain-facing; machinery stays below deck).
  • Authority is explicit: aligns as opt-in (no body unless --structured-file; no new grant).
  • Scripts own the mechanics: aligns (jq validation, atomic persist-before-hold, rollback).
  • A restart is a non-event: aligns (durable per-task JSON keyed by task id).
  • Delegation with a spine: mixed / cannot tell as auto. Existing primitives already record the captain's word (--decision-file prose, hold_kind=captain, legacy <origin>-decision-<key>, decision_keys= metadata, state/decision-bindings/). This adds a second schema fm-captain-decision.v1 (question / options[label,consequence] / recommendation / free_response) rather than composing those keys. A new task shape is not created, but a new durable decision shape is.
  • The fleet outlives any vendor: aligns.
  • Scope: aligns (does not touch Fleet or tasks-axi).

This HEAD: d37a7319f072df8f1034d91dc6be8335ca4df028. MERGEABLE / UNSTABLE, ahead 9 / behind 0.
Attestation 9487666be8007d964f335534c75ae5f68bf3582d ≠ THIS HEAD (later no-mistakes: apply CI fixes x2).
CI action_required: CI 32783675794, Require no-mistakes 32783675805. Not a first-time fork (dcalliari still has open #2448); workflows not approved this pass. Greptile is not a merge gate.

Security: none. Path-escaping task ids refused; records 0600; rollback restores prior body / removes a just-created task. Overlap: none with spawn-freshen / pool / herdr / lock holds.

Land-eligible rec: NO. Captain-flag NOW: no (author/CI: matching attestation + green CI still missing; do not escalate).

This is a captain-decision on whether extra structured records should exist beside the current decision keys. It is also waiting-on-author for a HEAD-matching no-mistakes-pipeline-attestation:v1. Not a merge I will recommend.

@dcalliari dcalliari closed this Aug 24, 2026
@dcalliari
dcalliari deleted the fm/fm-decisao-estruturada branch August 24, 2026 22:30
@dcalliari dcalliari changed the title feat(bin): add structured captain decision records Closed: opened against the wrong repository Aug 24, 2026
@dcalliari

dcalliari commented Aug 24, 2026 •

Copy link
Copy Markdown
Author

Closed. Opened by mistake against the wrong repository; the work does not belong upstream. (Firstmate decided to by its own)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants