feat(hermes): add Hermes as a first-class Firstmate primary backend - #1673
Closed
vaskarvelas wants to merge 13 commits into
Closed
vaskarvelas wants to merge 13 commits into
vaskarvelas wants to merge 13 commits into
Conversation
…ate lists, register new doc
vaskarvelas
force-pushed
the
fm/hermes-primary-herdr-visible-v2
branch
from
August 4, 2026 12:40
bf50479 to
2a9432d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Make Hermes Agent a first-class Firstmate primary Captain's Assistant while keeping every crewmate visible through the Herdr backend; preserve existing harness behavior and block invisible delegation.
What Changed
.hermes/plugins/firstmate-primary/plugin (__init__.py,plugin.yaml) andbin/fm-hermes-primary.sh, letting Hermes Agent act as a first-class Captain's Assistant primary.bin/fm-spawn.sh,bin/fm-backend.sh,bin/backends/herdr.sh,bin/fm-session-lock-lib.sh,bin/fm-harness-process-lib.sh,bin/fm-busy-lib.sh) so every crewmate stays visible through the Herdr backend and delegation cannot happen invisibly.tests/fm-hermes-primary.test.sh,tests/fm-hermes-harness.test.sh,tests/fm-secondmate-harness.test.sh, plus updates tofm-backend-herdr,fm-backend,fm-session-start,fm-spawn-dispatch-profiletests) and updated docs (docs/supervision-protocols/hermes.md,docs/architecture.md,docs/configuration.md,docs/codex-app-backend.md,README.md) to describe the new primary and fix stale duplicate backend lists.Risk Assessment
✅ Low: The Hermes-primary integration (plugin, process-identity helpers, session-lock/harness-detection wiring, and docs) is additive, gated behind strict scope checks (persistent-CLI launch shape, cwd==root, valid state dir), fails closed on ambiguity, blocks delegate_task and unsafe watcher-arm shapes, explicitly refuses Hermes as a crewmate/secondmate runtime in fm-spawn.sh, and is backed by targeted tests (fm-hermes-primary.test.sh, fm-hermes-harness.test.sh, fm-spawn-dispatch-profile.test.sh) that assert exactly these behaviors; existing harness protocols and herdr crewmate-visibility contracts are left untouched.
Testing
Ran the 5 test files most directly covering this change via bin/fm-test-run.sh; all passed with zero failures, and the assertions directly exercise delegation-blocking and Herdr crewmate visibility, satisfying the required user intent.
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
.agents/skills/bootstrap-diagnostics/SKILL.md- branch carries 18 commit(s) that exist on your local main branch but were never pushed to origin/main; rebasing would bundle this unrelated work (154 file(s)) into the PR:Push main to origin, or rebase your branch onto origin/main, before gating.
🔧 Fix applied.
1 warning still open:
.agents/skills/bootstrap-diagnostics/SKILL.md- branch carries 18 commit(s) that exist on your local main branch but were never pushed to origin/main; rebasing would bundle this unrelated work (154 file(s)) into the PR:Push main to origin, or rebase your branch onto origin/main, before gating.
✅ **Review** - passed
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
bin/fm-test-run.sh tests/fm-hermes-primary.test.shbin/fm-test-run.sh tests/fm-hermes-harness.test.shbin/fm-test-run.sh tests/fm-secondmate-harness.test.shbin/fm-test-run.sh tests/fm-backend-herdr.test.shbin/fm-test-run.sh tests/fm-backend.test.shgit status --short⏭️ **Document** - skipped
docs/verification/public-followup.md:96- Dated compatibility-axis review (2026-07-30) lists primary harnesses without Hermes, now incomplete per firstmate-coding-guidelines' harness-review rule. Low priority: it's a frozen verification snapshot, not a live contract, and re-running that review is out of scope for this doc-staleness pass.✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.