fix(bin): preserve full task contract in no-mistakes intent - #1447
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Ship the smallest tracked Firstmate change that makes the no-mistakes intent handoff preserve the full accepted task contract. Treat bin/fm-brief.sh as the sole owner of the no-mistakes ship definition of done, and add one concise instruction requiring a worker's no-mistakes --intent to preserve all relevant content from the generated brief's # Task section plus every later accepted Firstmate requirement, clarification, constraint, exclusion, and supersession. The intent must retain direct requirements rather than substituting a diff summary, exclude generic operational, status, delivery, and other scaffold boilerplate unless it is task-specific, and carry the current accepted requirement when a later instruction supersedes an earlier one. Do not add a separate intent file, a long section, or duplicate this contract into AGENTS.md, harness-adapters, unrelated skills, or unrelated docs. Reproduce the current generated no-mistakes ship brief through bin/fm-brief.sh's public interface before editing, and add or update colocated executable public-interface tests covering the no-mistakes ship variant and showing other delivery variants are unaffected where relevant, without asserting implementation source bytes. Follow the one-owner rule, one-sentence-per-line Markdown style, documentation audience checks, repository lint, focused tests, and the configured no-mistakes pipeline. This work is independent of PR 1446 and must not change, synchronize, recover, resume, validate, or merge it or any associated preserved work.
What Changed
--intentto preserve the complete current task contract, retain direct requirements, and omit non-task-specific scaffold boilerplate.Risk Assessment
✅ Low: The updated single-owner instruction now preserves all relevant task content, explicitly retains only current accepted requirement forms after supersession, excludes non-task-specific scaffold boilerplate, and remains isolated to the no-mistakes delivery variant with public-interface coverage.
Testing
No separate baseline commands were supplied; the focused
fm-briefpublic-interface test passed, manual end-to-end generation showed the complete current-task intent contract only in the no-mistakes ship brief, both other delivery variants remained unaffected, reviewer-visible brief artifacts were captured, and transient worktree fixtures were removed.Evidence: No-mistakes ship brief
Evidence: Direct-PR control brief
Evidence: Local-only control brief
Evidence: Delivery-variant evidence summary
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
🔧 **Review** - 1 issue found → auto-fixed ✅
bin/fm-brief.sh:341- The required contract says--intentmust preserve “all relevant content” from# Taskand carry the current accepted requirement after supersession. This instruction narrows that to “every relevant requirement” and merely includes “supersessions,” so relevant context can still be omitted and obsolete requirements can remain alongside replacements. Update this sole owner to require all relevant task content and only each requirement's current accepted form.🔧 Fix: Preserve complete current task contract in no-mistakes intent
✅ Re-checked - no issues remain.
✅ **Test** - passed
✅ No issues found.
Inspectedgit diff a805766622afb291681a15a80c5135517f1cb5ed..95586b0b820ab165ed96dc1370738031cc04649b -- bin/fm-brief.sh tests/fm-brief.test.shand both target commits.Ran./tests/fm-brief.test.sh.Generated no-mistakes, direct-PR, and local-only ship briefs throughbin/fm-brief.shwith an isolated delivery-mode registry.Verified the generated no-mistakes brief contains exactly one complete intent-handoff instruction, while direct-PR and local-only briefs contain none.Verified all three generated evidence briefs are present and non-empty, then confirmedgit status --shortis clean.✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.