This repository has been archived by the owner on Aug 20, 2024. It is now read-only.
Remove unloaded objects from nested relationshps #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of the issue
Let's say we have nested objects to save:
and we create a new ticket (which belongs to the show).
In that case, the reset relationships function doesn't remove the created in the store record from the list of tickets.
Before save:
after save:
The explanation of the fix
Now, we properly remove the
null
object from the relationships and unload it.Basically, we just had to remove that from the correct parent. Before, the extension was trying to remove
ticket
from top-level object (i.e.event
)