Skip to content

chore(kds): stop using deprecated otelgrpc.UnaryServerInterceptor#8911

Merged
michaelbeaumont merged 1 commit into
kumahq:masterfrom
michaelbeaumont:chore/deprecated-otelgrpc
Jan 19, 2024
Merged

chore(kds): stop using deprecated otelgrpc.UnaryServerInterceptor#8911
michaelbeaumont merged 1 commit into
kumahq:masterfrom
michaelbeaumont:chore/deprecated-otelgrpc

Conversation

@michaelbeaumont
Copy link
Copy Markdown
Contributor

@michaelbeaumont michaelbeaumont commented Jan 18, 2024

We were intentionally using the deprecated version but the issue seems to have been fixed by open-telemetry/opentelemetry-go-contrib#4577 which was released in v0.46.1 which we're using

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner January 18, 2024 11:29
@michaelbeaumont michaelbeaumont requested review from jakubdyszkiewicz, lobkovilya and slonka and removed request for a team January 18, 2024 11:29
Comment thread pkg/kds/mux/server.go
@michaelbeaumont michaelbeaumont merged commit bffa14f into kumahq:master Jan 19, 2024
@michaelbeaumont michaelbeaumont deleted the chore/deprecated-otelgrpc branch January 19, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants