Skip to content

chore(*) upgrade Envoy to v1.19.1#2701

Closed
jpeach wants to merge 1 commit intokumahq:masterfrom
jpeach:chore/upgrade-envoy-1.19.1
Closed

chore(*) upgrade Envoy to v1.19.1#2701
jpeach wants to merge 1 commit intokumahq:masterfrom
jpeach:chore/upgrade-envoy-1.19.1

Conversation

@jpeach
Copy link
Copy Markdown
Contributor

@jpeach jpeach commented Aug 30, 2021

Signed-off-by: James Peach james.peach@konghq.com

Summary

Upgrade to Envoy v1.19.1 (release notes).

Full changelog

  • Upgrade Envoy to v1.19.1

Issues resolved

N/A

Documentation

N/A

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

Signed-off-by: James Peach <james.peach@konghq.com>
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #2701 (052733a) into master (203c072) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2701      +/-   ##
==========================================
+ Coverage   52.23%   52.26%   +0.03%     
==========================================
  Files         864      864              
  Lines       49219    49219              
==========================================
+ Hits        25710    25725      +15     
+ Misses      21424    21406      -18     
- Partials     2085     2088       +3     
Impacted Files Coverage Δ
pkg/kds/client/sink.go 52.27% <0.00%> (+4.54%) ⬆️
pkg/core/resources/manager/cache.go 84.41% <0.00%> (+5.19%) ⬆️
pkg/core/bootstrap/autoconfig.go 54.46% <0.00%> (+8.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 203c072...052733a. Read the comment docs.

@jakubdyszkiewicz
Copy link
Copy Markdown
Contributor

Note: Before merging, we need to make sure that new Envoy binaries are up in https://download.konghq.com/mesh-alpine/

@jpeach
Copy link
Copy Markdown
Contributor Author

jpeach commented Aug 31, 2021

Envoy broke DNS filter compatibility between 1.18 and 1.19. Not sure how we are going to be able to upgrade past this. IIUC, we can't require a big-bang conversion to Envoy 1.19.

envoyproxy/envoy#16237

@jpeach
Copy link
Copy Markdown
Contributor Author

jpeach commented Aug 31, 2021

Note: Before merging, we need to make sure that new Envoy binaries are up in https://download.konghq.com/mesh-alpine/

How do we do that?

@jpeach
Copy link
Copy Markdown
Contributor Author

jpeach commented Sep 1, 2021

Abandoning the 1.19.1 upgrade. Hopefully we will be able to upgrade to 1.19.2 if the upstream protobuf changes work out.

@jpeach jpeach closed this Sep 1, 2021
@jpeach
Copy link
Copy Markdown
Contributor Author

jpeach commented Sep 1, 2021

xref #2713

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants