Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

Add sequence mode for audio #119

Closed
wants to merge 1 commit into from
Closed

Conversation

mzlarsson
Copy link
Contributor

Makes it possible to specify multiple assets and we will play them directly after one another, as a single action. It is also possible to give the sequenceLooping argument to specify the number of loops for each clip. This allows you to for example have one clip, then a looping paus (now-are-the-characters-talking) clip in the middle and then another clip without explicitly timing the start of each clip. This could allow for smoother transitions between songs that need to be split in looping parts.

@AntonNeld
Copy link
Member

It makes sense to have this functionality regardless (except maybe the number of loops), but this is about Hackermusik II, right? Don't we want to trigger going from the loop to the next part of the song manually, instead of looping it a fixed number of times?

@mzlarsson
Copy link
Contributor Author

It makes sense to have this functionality regardless (except maybe the number of loops), but this is about Hackermusik II, right? Don't we want to trigger going from the loop to the next part of the song manually, instead of looping it a fixed number of times?

Yeah it is. My thought was that you set the looping to be infinite and then we can just toggle looping to OFF in the UI to move on to the next part.

@@ -84,6 +102,10 @@ module.exports = class AudioHandler extends MediaHandler {
this.stopFade();
this.setMuted(!this.isMuted());
break;
case 'toggle_loop':
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part (and toggleLoop below) is required for Ragnarök. Should I do a separate PR with just these parts perhaps?

@mzlarsson
Copy link
Contributor Author

We found another solution and made toggleLoop in its own PR.

@mzlarsson mzlarsson closed this Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants