Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(devs-infra): replace node 12 with node 18 for CI #3766

Merged
merged 1 commit into from
Aug 25, 2022
Merged

build(devs-infra): replace node 12 with node 18 for CI #3766

merged 1 commit into from
Aug 25, 2022

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Aug 25, 2022

Summary

Prepare for v29

Test plan

Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2928703013

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 95.95%
Files with Coverage Reduction New Missed Lines %
src/legacy/config/config-set.ts 8 97.33%
Totals Coverage Status
Change from base Build 2928400466: -0.2%
Covered Lines: 3971
Relevant Lines: 4062
💛 - Coveralls

@ahnpnl ahnpnl marked this pull request as ready for review August 25, 2022 18:17
@ahnpnl ahnpnl merged commit e925f10 into kulshekhar:main Aug 25, 2022
@ahnpnl ahnpnl deleted the infra/increase-node-version branch August 25, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulshekhar kulshekhar kulshekhar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahnpnl @coveralls @kulshekhar