Migrate tslint to eslint #1590
Merged
Migrate tslint to eslint #1590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imas/ts-jest into migrate-tslint-to-eslint
This change is detect where there might be issues with referencing ´this´ from the rule definition (https://github.com/typescript-eslint/typescript-eslint/blob/v2.30.0/packages/eslint-plugin/docs/rules/unbound-method.md) : `Warns when a method is used outside of a method call. Class functions don't preserve the class scope when passed as standalone variables.`
Bumps [jest](https://github.com/facebook/jest) from 25.5.3 to 25.5.4. - [Release notes](https://github.com/facebook/jest/releases) - [Changelog](https://github.com/facebook/jest/blob/master/CHANGELOG.md) - [Commits](jestjs/jest@v25.5.3...v25.5.4) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
|
look quite a lot files to review but it's easier to review against |
|
Sorry about that, bear in mind that the changes to existing files are minimal and should only be linting fixes with tabs and such :) The most noticable changes are done in
|
Pull Request Test Coverage Report for Build 4670
💛 - Coveralls |
ahnpnl
reviewed
May 2, 2020
|
@ahnpnl I think all the review comments are done in the last commit :) |
ahnpnl
reviewed
May 2, 2020
|
I'm reading warning logs in CI. Probably we need to fix them, either disable eslint check for code or fix the code itself. |
ahnpnl
reviewed
May 2, 2020
…imas/ts-jest into migrate-tslint-to-eslint
It was my vscode that messed things up, I had wrong tabs :) |
ahnpnl
reviewed
May 2, 2020
…imas/ts-jest into migrate-tslint-to-eslint
…imas/ts-jest into migrate-tslint-to-eslint
…imas/ts-jest into migrate-tslint-to-eslint
…imas/ts-jest into migrate-tslint-to-eslint
ahnpnl
approved these changes
May 2, 2020
|
@kulshekhar would you please take a look if any rules we need to adjust ? |
kulshekhar
reviewed
May 3, 2020
kulshekhar
reviewed
May 3, 2020
kulshekhar
approved these changes
May 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1566
Making changes to configuration files where we want to migrate from deprecated tslint to eslint.
Does this PR introduce a breaking change?
Currently, there are some errors in the linting which breaks tests, but those are regarding prettier formatting mostly. Other errors have been put to warning. These can either be handled or put to off in .eslintrc
Other information
I was initially considering to add eslint-plugin-import to lint some errors regarding import syntax, ordering and stuff but that heavily degraded the performance of the linting.
Here is with:
Without: