test: correct unit tests and e2e tests for language service #1579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahnpnl
commented
Apr 29, 2020
| @@ -172,8 +170,7 @@ export const initializeLanguageServiceInstance = ( | |||
| * test file for 1st time run after clearing cache because | |||
| */ | |||
| return ( | |||
| entry[1].modulePaths.find(modulePath => modulePath === fileName) && | |||
| !hasOwn.call(memoryCache.files, entry[0]) | |||
| entry[1].modulePaths.find(modulePath => modulePath === fileName) && !memoryCache.files.has(entry[0]) | |||
There was a problem hiding this comment.
I modified our internal memory cache in #1574 but forgot this one. It doesn't cause any bugs or performance issue but 'the fastest code is the code which does nothing' so it's better to correct this condition.
| logTarget.clear() | ||
| compiler.compile(importedModuleSrc, require.resolve('../__mocks__/unchanged-modules/main.ts')) | ||
|
|
||
| expect(logTarget.filteredLines(LogLevels.debug, Infinity)).toMatchInlineSnapshot(` |
There was a problem hiding this comment.
We just need to verify logging for assertion related to https://github.com/kulshekhar/ts-jest/pull/1579/files#diff-124008e76d6a710666b8d995ffc3758fR173 (the condition which is fixed in the below comment)
Pull Request Test Coverage Report for Build 4613
💛 - Coveralls |
kulshekhar
approved these changes
Apr 30, 2020
ahnpnl
added a commit
that referenced
this pull request
Apr 30, 2020
ahnpnl
added a commit
that referenced
this pull request
May 1, 2020
ahnpnl
added a commit
that referenced
this pull request
May 1, 2020
ahnpnl
added a commit
that referenced
this pull request
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added unit tests for
language-service.tsand remove unnecessary e2e tests.Test plan
Green CI
Does this PR introduce a breaking change?
Other information
N.A.