Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(e2e): add nrwl-nx to e2e external test cases #1519

Merged
merged 3 commits into from
Apr 10, 2020
Merged

chore(e2e): add nrwl-nx to e2e external test cases #1519

merged 3 commits into from
Apr 10, 2020

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Apr 9, 2020

Summary

I see ts-jest is used by a lot popular repos/frameworks. I think it makes sense that we need an example of those popular repos/frameworks to our e2e. This PR:

  • adds nrwl nx workspace to e2e external repos test.
  • rename folder __monorepos__ to __external-repos.

Test plan

Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@ahnpnl ahnpnl requested a review from kulshekhar as a code owner April 9, 2020 12:43
@coveralls
Copy link

coveralls commented Apr 9, 2020

Pull Request Test Coverage Report for Build 4404

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.944%

Totals Coverage Status
Change from base Build 4403: 0.0%
Covered Lines: 1160
Relevant Lines: 1195

💛 - Coveralls

@ahnpnl ahnpnl merged commit 232c458 into kulshekhar:master Apr 10, 2020
@ahnpnl ahnpnl deleted the test-external branch April 10, 2020 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants