Skip to content

Conversation

anchor123
Copy link

  1. 添加了外部css内容处理函数,转换相对路径为绝对路径,防止加载失败。(针对引入外部cdn的情况)
  2. 添加了对应的单元测试内容

@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2021

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.42%. Comparing base (ab3e788) to head (2ce721d).
Report is 36 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
+ Coverage   80.76%   81.42%   +0.65%     
==========================================
  Files           3        3              
  Lines         338      350      +12     
  Branches      116      118       +2     
==========================================
+ Hits          273      285      +12     
  Misses         59       59              
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anchor123
Copy link
Author

@kuitos 作者您好,请问这个更改OK吗?能否发布到最新版呢

// by daniel@2021-06-22
let newBaseURI = baseURI;
if (baseURI.indexOf('//') === 0) {
newBaseURI = 'http:' + baseURI;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

喔嚯, 兄弟,你这不考虑 https 吗?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants