chore: RSC 対応テストから漏れているコンポーネントを追加 #5005
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
s-sasaki-0529
commented
Oct 11, 2024
| 'TimePicker', | ||
| 'SpreadsheetTableCorner', | ||
| 'HeaderLink', | ||
| 'DropdownScrollArea', |
There was a problem hiding this comment.
これで多分洗い出し一通り完了。
思ったよりRSC対応してるコンポーネント多いなという印象。
s-sasaki-0529
requested review from
moshisora and
hiroki0525
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
RSC対応テスト関連PR
概要
RSC対応テストでは、すべてのコンポーネントの検証を行うようにしているが、対象コンポーネントに漏れが残っていたので追加します。
変更内容
全コンポーネントを洗い出したリストから、まだRSC対応テストに追加していないコンポーネントを抜き出して追加
確認方法
コード差分を確認して、CIが通っていることがわかればOK