Skip to content
This repository has been archived by the owner on Feb 15, 2024. It is now read-only.

Fix spec on GitHub actions #31

Merged
merged 2 commits into from
Jun 21, 2021
Merged

Conversation

mkmn
Copy link
Contributor

@mkmn mkmn commented Jun 14, 2021

Description

I introduced Github Actions in #29.
However, the test was failing, so I will fix it.

Changes

  • Set Default value to ENV['EGOV_API_END_POINT']
    • EGOV_API_END_POINT is required for spec.
  • Use tmpdir.
    • Currently, we have to create a separate temporary folder, and the data remains even after the test is over.
    • One test is dependent on a file created by another test.

mkmn added 2 commits June 14, 2021 13:27
Because I want to be able to run tests without having to create env files.
Currently, we have to create a separate temporary folder, and the data remains even after the test is over.
@mkmn mkmn requested a review from a team as a code owner June 14, 2021 06:12
@mkmn mkmn requested review from f440 and kouryou and removed request for a team June 14, 2021 06:12
Copy link
Member

@f440 f440 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@kouryou kouryou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mkmn
Copy link
Contributor Author

mkmn commented Jun 21, 2021

thx.

@mkmn mkmn merged commit cc2a6fa into kufu:master Jun 21, 2021
@mkmn mkmn deleted the github_actions_successful branch June 21, 2021 07:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants