Sitemap Index and Splitting into multiple sitemaps #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
somehow there was some conflict, but I resolved this. Hope this meets your requirements. |
|
@Matzu89 thank you! But TravisCI show some lint errors. Can you fix it? |
kuflash
reviewed
May 31, 2017
lib/index.js
Outdated
| this.sitemap = buildSitemap(hostname, this.paths); | ||
| build(hostname) { | ||
| this.hostname = hostname; | ||
| this.splitted = splitPaths(this.paths, 49999); |
There was a problem hiding this comment.
The number of paths must be made an optional parameter. By default it equal 49999.
Create second argument options as object and add property limitCountPaths.
For example:
build('https://example.com', { limitCountPaths: 1000 })
kuflash
reviewed
May 31, 2017
lib/paths-splitter/index.js
Outdated
|
|
||
| const pathsSplitter = (paths, size) => paths.map((e, i) => { | ||
| return (i % size === 0) ? paths.slice(i, i + size) : null; | ||
| }).filter(e => e); |
There was a problem hiding this comment.
Please rename e to path for more readability
|
@Matzu89 also please add unit tests for new module |
|
Your request is my demand. Executed, this should do the trick. |
|
@Matzu89 cool! |
kuflash
added a commit
that referenced
this pull request
Jun 1, 2017
* Generate Sitemap Index and Splitting into multiple sitemaps (#51) * Update documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements as described in #49