Skip to content

Conversation

@bjfish
Copy link
Contributor

@bjfish bjfish commented Sep 8, 2020

I have been testing TruffleRuby for compatibility and there are only 2 failures in the current ruby-oci8 test suite with the truffleruby-head version. I would like to propose another PR later to add this to CI once the 2 failures have been fixed.

@kubo
Copy link
Owner

kubo commented Sep 10, 2020

Thank you!
I found another issue about compiling on linux using TruffleRuby. I'll fix it later.

@bjfish bjfish deleted the truffleruby-engine branch September 10, 2020 14:29
@eregon
Copy link

eregon commented Sep 22, 2020

Hello @kubo, which compilation issue did you mean above? Is that fixed?

@kubo
Copy link
Owner

kubo commented Sep 23, 2020

@eregon
I fixed it locally but have not pushed it to github yet.
When plthook_elf.o doesn't exist in ext/oci8, ruby extconf.rb fails.

...
checking for rb_class_superclass() in ruby.h... yes
checking for rb_thread_call_without_gvl() in ruby/thread.h... yes
checking for rb_sym2str() in ruby.h... yes
checking for plthook... <internal:core> core/errno.rb:48:in `handle': No such file or directory (Errno::ENOENT)
	from <internal:core> core/file.rb:1153:in `block in unlink'
	from <internal:core> core/file.rb:1151:in `each'
	from <internal:core> core/file.rb:1151:in `unlink'
	from extconf.rb:159:in `<main>'

It is due to https://github.com/oracle/truffleruby/blob/vm-20.2.0/lib/mri/mkmf.rb#L578-L581.

@eregon
Copy link

eregon commented Sep 23, 2020

Mmh, that branch should have no effect, because we use standard extensions now (.o for objects, .so for shared libraries on Linux).
I'll try to reproduce.

@eregon
Copy link

eregon commented Sep 26, 2020

I've removed that change in mkmf.rb: truffleruby/truffleruby@6f66e81

kubo added a commit that referenced this pull request Sep 28, 2020
When pltook_*.c is successfully compiled in extconf.rb, plthook_*.$OBJEXT
is removed by File.delete. However TruffleRuby 20.2 or before creates
conftest.$OBJEXT. If plthook_*.$OBJEXT isn't compiled before, extconf.rb fails.
(GH-225)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants