This repository has been archived by the owner on Apr 28, 2020. It is now read-only.
Backport 557, BZ 1756328: Use volumeDevices for Block volumeMode #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1756328 Signed-off-by: Marek Libra <[email protected]>
To make flows in the conversion pod easier, the temporary disk is requested with the Filesystem volumeMode no matter of the kubevirt-storage-class-defaults values. The temporary space for the conversion pod is requested on the default storage class. The "Filesystem" volumeMode seems to be safe, supported by all storage classes. The target disks for the v2v stay untouched, this change affects just the temporary space. Signed-off-by: Marek Libra <[email protected]> Conflicts: - src/k8s/requests/v2v/importVmware.js
mareklibra
force-pushed
the
backport.557.v2v.volumeDevices.Block
branch
from
df2860d to
5407d37
Compare
Pull Request Test Coverage Report for Build 1987
💛 - Coveralls |
mareklibra
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of: #557
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1756328