Skip to content
This repository has been archived by the owner on Apr 28, 2020. It is now read-only.

feat(react-charts): update patternfly react-charts usage #550

Merged
merged 1 commit into from
Sep 12, 2019

Conversation

priley86
Copy link
Contributor

@priley86 priley86 commented Sep 11, 2019

updates the @patternfly and react-charts usage.

cc: @vojtechszocs @TheRealJon

When running w/ latest dependencies in #2340, i'm seeing these (since our API changed):

98% after emitting WebpackDevMiddlewareType checking in progress...
⚠ 「wdm」:    9170 modules

WARNING in ./node_modules/kubevirt-web-ui-components/dist/esm/components/Dashboard/Capacity/CapacityItem.js 79:13-23
"export 'ChartTheme' was not found in '@patternfly/react-charts'

WARNING in ./node_modules/kubevirt-web-ui-components/dist/esm/components/StorageOverview/TopConsumers/TopConsumers.js 52:13-23
"export 'ChartTheme' was not found in '@patternfly/react-charts'

WARNING in ./node_modules/kubevirt-web-ui-components/dist/esm/components/StorageOverview/TopConsumers/TopConsumers.js 104:13-23
"export 'ChartTheme' was not found in '@patternfly/react-charts'

WARNING in ./node_modules/monaco-editor-core/esm/vs/editor/common/services/editorSimpleWorker.js 374:12-383:17
Critical dependency: the request of a dependency is an expression
ℹ 「wdm」: Compiled with warnings.

Copy link

@TheRealJon TheRealJon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@mareklibra mareklibra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are more things to change after openshift/console#2611, so related to the openshift/console#2611 as well.

I am currently working on fixes after openshift/console#2611 , namely dropdowns and kebabs. I will most probably need to fix pf-react/consoles as well.

@mareklibra mareklibra merged commit 00a00a6 into kubevirt:master Sep 12, 2019
@coveralls
Copy link

coveralls commented Sep 16, 2019

Pull Request Test Coverage Report for Build 2314

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.821%

Totals Coverage Status
Change from base Build 1934: 0.0%
Covered Lines: 4202
Relevant Lines: 4858

💛 - Coveralls

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants