This repository has been archived by the owner on Apr 28, 2020. It is now read-only.
Namespaces for kubevirt-storage-class-defaults and v2v-vmware #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The KubevirtVmwareConfigMap was supposed to be well-named and present in a single namespace only. As this requirement has changed, this patch introduces searching for the ConfigMap in a list of namespaces while respecting their order.
The `kubevirt-storage-class-defaults` config map was supposed to be well-named and present in a single namespace only. As this requirement has changed, this patch introduces searching for the ConfigMap in a list of namespaces while respecting their order.
mareklibra
changed the title
Pull Request Test Coverage Report for Build 2278
💛 - Coveralls |
atiratree
reviewed
Aug 23, 2019
|
|
||
| export const getVmwareConfigMap = async props => { | ||
| // query namespaces sequentially to respect order | ||
| for (let index = 0; index < VMWARE_KUBEVIRT_VMWARE_CONFIG_MAP_NAMESPACES.length; index++) { |
There was a problem hiding this comment.
I get that the warns are different, but can we make at least this part generic? and add the comment from getVmwareConfigMapInNamespace to this function?
|
The best way to find the config map is to look for the namespace of the HCO CR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue with changing location of ConfigMaps in different releases.
The
kubevirt-storage-class-defaultsConfigMap is attempted to be retrieved from theopenshift-cnvfirst, then fromopenshiftin case of error.The
v2v-vmwareConfigMap is read fromopenshift-cnvnamespace first, then fromkubevirt-hyperconverged.