This repository has been archived by the owner on Apr 28, 2020. It is now read-only.
Add new host states #356
Merged
Add new host states #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1287
💛 - Coveralls |
atiratree
suggested changes
Apr 15, 2019
src/components/BareMetalHosts/fixtures/BaremetalHostStatus.fixture.js
Outdated
Show resolved
Hide resolved
src/components/BareMetalHosts/tests/BaremetalHostStatus.test.js
Outdated
Show resolved
Hide resolved
jtomasek
approved these changes
Apr 16, 2019
flofuchs
force-pushed
the
new-host-states
branch
2 times, most recently
from
2c806de to
ef164bc
Compare
atiratree
suggested changes
Apr 16, 2019
| it('renders a generic success message', () => { | ||
| const component = shallow(testBaremetalHostStatusSuccess()); | ||
| expect(component).toMatchSnapshot(); | ||
| it('renders the correct subcomponent', () => { |
There was a problem hiding this comment.
it should be inside the forEach for easier debugging + please also include the fixture index in it message + optionally the status
There was a problem hiding this comment.
Good point, thanks. I made the message more descriptive by adding the status but omitted the index because that would make the message ugly and wouldn't add to its meaning.
There was a problem hiding this comment.
indexes add uniqueness to the test case. This will break once you check for the same statuses in multiple fixtures (different conditions - same status)
Adding 3 new provisioning states: - match profile - provisioning error - power management error
flofuchs
force-pushed
the
new-host-states
branch
from
ef164bc to
f81dff7
Compare
atiratree
approved these changes
Apr 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding 3 new provisioning states: