-
Notifications
You must be signed in to change notification settings - Fork 30
Conversation
@rawagner Agreed, Will amend the PR. Thanks! |
4101e90
to
9d5d4d5
Compare
9d5d4d5
to
b2931e1
Compare
Pull Request Test Coverage Report for Build 1462
💛 - Coveralls |
b2931e1
to
3e31f22
Compare
@rawagner @suomiy , I've made the requested changes and amended the PR. Please review. BEFORE- AFTER- The changes I've made are-
Reference Doc - https://docs.google.com/presentation/d/15nDG3VuQRy6vJbMX4yq6ZvJ5G2Qawaz9glnLT8GEvX4/edit#slide=id.g4fa43fba25_0_0 |
</DashboardCardBody> | ||
</DashboardCard> | ||
); | ||
const HealthStatus = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not change data format from the previous one, we are not using the same as in OCS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would split the PR to two - first one would contain new generic HealthBody/Item for Dashboard + Health in StorageOverview. I will create second one which changes ClusterOverview health to use HealthBody/Item from Dashboard - as this will probably require changes in web-ui too
3e31f22
to
0d5dee0
Compare
@rawagner Rolled back the changes for the cluster overview and made the requested changes. Note: Build failing with error - |
0d5dee0
to
0989306
Compare
Added the health folder in dashboard so that it's generic and can be used across components. Working remains the same.