Skip to content
This repository has been archived by the owner on Apr 28, 2020. It is now read-only.

Utilization: Add Disk Usage chart #322

Merged
merged 1 commit into from
Apr 11, 2019

Conversation

mareklibra
Copy link
Contributor

@mareklibra mareklibra commented Apr 8, 2019

and refactor prometheus queries for disk capacity so they
can be reused for utilization.

@coveralls
Copy link

coveralls commented Apr 8, 2019

Pull Request Test Coverage Report for Build 1310

  • 11 of 11 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 87.331%

Totals Coverage Status
Change from base Build 1297: 0.03%
Covered Lines: 3193
Relevant Lines: 3507

💛 - Coveralls

@mareklibra
Copy link
Contributor Author

In the memory/storage utilization charts, the total is used as maximum for Y-axis.

If total is much higher than actual consumption, the chart does not show "progress" vividly as the consumption is nearly to be a constant.

What about using

  • maximal historic value (from the given range) as Y-axis maximum
  • but units (KiB, TiB, etc) from the total?

What others think?

@rawagner
Copy link
Contributor

rawagner commented Apr 8, 2019

I would vote for using value AND units from max historic value

@mareklibra
Copy link
Contributor Author

And yet another (better) possibility handling the case with "almost constant" values within the range:
For max-y, use max historic value multiplied by 2 or cluster's capacity total, whatever is lower.

This approach handles:

  • near-constant values
  • values << total

@mareklibra mareklibra force-pushed the utilization.diskUsage branch from 61ff987 to d3e051d Compare April 9, 2019 08:05
@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 9, 2019
and refactor prometheus queries ofr disk capacity so they
can be reused for utilization.
@mareklibra mareklibra force-pushed the utilization.diskUsage branch from d3e051d to 6d00abc Compare April 9, 2019 08:35
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 9, 2019
@atiratree
Copy link
Contributor

+1

@rawagner rawagner merged commit 185194f into kubevirt:master Apr 11, 2019
@mareklibra mareklibra mentioned this pull request Apr 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants