This repository has been archived by the owner on Apr 28, 2020. It is now read-only.
Fix vmStatus ordering #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1170
💛 - Coveralls |
atiratree
approved these changes
Mar 28, 2019
atiratree
reviewed
Mar 28, 2019
src/utils/status/vm/vmStatus.js
Outdated
| @@ -138,12 +138,12 @@ const isWaitingForVmi = vm => { | |||
| }; | |||
|
|
|||
| export const getVmStatus = (vm, launcherPod, importerPods, migration) => | |||
| isBeingMigrated(vm, migration) || // must be precceding isRunning() since vm.status.ready is true for a migrating VM | |||
| isBeingMigrated(vm, migration) || // must precede isRunning() since vm.status.ready is true for a migrating VM | |||
| isBeingImported(vm, importerPods) || // must precede isRunning() since importing status doesn't rely on running status | |||
There was a problem hiding this comment.
@mareklibra can you please double check the order here?
kubevirt-bot
added
the
needs-rebase
pcbailey
force-pushed
the
vm-status-order
branch
from
d1342f4 to
551f101
Compare
kubevirt-bot
removed
the
needs-rebase
pcbailey
changed the title
mareklibra
approved these changes
Apr 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the ordering of VM statuses in vmStatus to check importing status before running status to avoid the VM reflecting a status of "Off" when it is actually in "Importing" status.