This repository was archived by the owner on Apr 28, 2020. It is now read-only.
Add 'dev' script to do a development build#166
Merged
mareklibra merged 1 commit intokubevirt:masterfrom Jan 9, 2019
Merged
Conversation
mareklibra
approved these changes
Jan 9, 2019
Contributor
|
Watch mode would be nice to have though. Mainly because web-ui dev watch mode breaks when we delete our dist. Then, web-ui dev needs to be restarted. web-ui dev output: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing comment #150 (comment)
devscript to do a development build (one-time) without any pre-checksbuildscript) hasNODE_ENVset accordinglyQ: why not use
--watchfor thedevscript?A: our build is split into two parts, JS and Sass. JS files are processed by Babel, Sass files are copied as-is. While Babel supports
--copy-filesto include files that weren't part of the JS compilation, this would require changing--out-dirand transforming file paths, for which I didn't find any suitable Babel plugin. We could use webpack and its watch mode on top of Babel, but I'm reluctant to add such complexity for now.Q: is there actually a difference between production and development build?
A: not right now 😃 it seems like
NODE_ENVhas no effect on our build outputs at the moment: