This repository was archived by the owner on Apr 28, 2020. It is now read-only.
Update dependencies and bump React version#139
Merged
mareklibra merged 1 commit intokubevirt:masterfrom Dec 7, 2018
Merged
Conversation
vojtechszocs
force-pushed
the
update-deps
branch
from
b03f6bf to
f72d395
Compare
Closed
Contributor
|
@vojtechszocs , I agree with these changes. |
mareklibra
approved these changes
Dec 7, 2018
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to issue #136.
reactandreact-dompeer dependencies have their versions loosened from16.3.xto16.x. This aligns with Console UI currently depending onreact-dom@16.x.reactandreact-domversion locks bumped to16.6.3. This aligns with Console UI currently depending onreact@16.6.3.Following dependencies are now treated as regular
dependencies:@patternfly/react-consolejs-yamllodashreact-dndreact-dnd-html5-backendreactabular-dndEverything in
devDependenciesis now truly needed for build/development only (except for entries that must matchpeerDependencies).@mareklibra @rawagner Console UI package.json already contains
react-dndandreact-dnd-html5-backend. It seems that we could treat these as peer dependencies fromkubevirt-web-ui-componentsperspective - what do you think?