This repository has been archived by the owner on Apr 28, 2020. It is now read-only.
Add DesktopViewer to VmConsoles #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 462
💛 - Coveralls |
Pull Request Test Coverage Report for Build 588
💛 - Coveralls |
3 tasks
With this patch the DesktopViewer is added among other console types.
mareklibra
force-pushed
the
DesktopViewer
branch
from
16d6444 to
3fa5856
Compare
The component renders user info for missing Service object for the RDP.
mareklibra
force-pushed
the
DesktopViewer
branch
from
3fa5856 to
d4c8b42
Compare
VM:
spec:
template:
metadata:
labels:
are now automatically populated by:
vm.cnv.io/name: ${VM_NAME}
mareklibra
force-pushed
the
DesktopViewer
branch
from
ea82276 to
c0fe95f
Compare
mareklibra
changed the title
rawagner
suggested changes
Jan 7, 2019
sass/components/_VmConsoles.scss
Outdated
| @@ -2,3 +2,7 @@ | |||
| padding-bottom: 12px !important; | |||
| margin-top: -14px !important; | |||
| } | |||
|
|
|||
| .vm-consoles-no-rdp .expand-collapse-pf-link-container { | |||
There was a problem hiding this comment.
please use BEM with kubevirt prefix
| For better experience accessing Windows console, it is recommended to use the RDP. To do so, create a service: | ||
| <ul> | ||
| <li> | ||
| exposing the <b>3389/tcp</b> port of the virtual machine |
There was a problem hiding this comment.
You already have RDP constant in kubevirt/web-ui#129 . I propose to move it to web-ui-components and reuse it in this text.
| exposing the <b>3389/tcp</b> port of the virtual machine | ||
| </li> | ||
| <li> | ||
| using selector: <b>vm.cnv.io/name: {vm.metadata.name}</b> |
There was a problem hiding this comment.
use constant TEMPLATE_VM_NAME_LABEL
| </li> | ||
| </ul> | ||
| Make sure, the VM object has <b>spec.template.metadata.labels</b> set to{' '} | ||
| <b>vm.cnv.io/name: {vm.metadata.name}</b> |
There was a problem hiding this comment.
use constant TEMPLATE_VM_NAME_LABEL
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this patch the DesktopViewer is added among other console types.
TODO: