Skip to content
This repository was archived by the owner on Apr 28, 2020. It is now read-only.

Remove tools folder from coverate report#101

Merged
atiratree merged 1 commit intokubevirt:masterfrom
rawagner:coverate_tools
Nov 14, 2018
Merged

Remove tools folder from coverate report#101
atiratree merged 1 commit intokubevirt:masterfrom
rawagner:coverate_tools

Conversation

@rawagner
Copy link
Contributor

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 287

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.7%) to 63.627%

Totals Coverage Status
Change from base Build 283: 2.7%
Covered Lines: 441
Relevant Lines: 621

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 367

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.7%) to 63.627%

Totals Coverage Status
Change from base Build 283: 2.7%
Covered Lines: 441
Relevant Lines: 621

💛 - Coveralls

@atiratree
Copy link
Contributor

Even though we have tests in tools I agree that we do not have to collect coverage on that.

@atiratree atiratree merged commit 0f598ea into kubevirt:master Nov 14, 2018
@rawagner rawagner deleted the coverate_tools branch November 19, 2018 13:24
@vojtechszocs
Copy link
Contributor

I've just found this out. What's the reasoning behind this change? Tools are used to validate the project during the build, why aren't their tests important enough? 😕

@rawagner
Copy link
Contributor Author

rawagner commented Jan 7, 2019

I wanted to collect coverage from the bits that we are actually shipping, but you are right, this is being used during the build so we should re-enable coverage report from tools dir.

@atiratree
Copy link
Contributor

@vojtechszocs the tests are important (their coverage is also important).
This is just a scope issue. If we want our coverage to include just the application or the application and the tools.

The best solution IMO is to have two coverage reports (one special for tools).

I don't mind having the coverage or not having the coverage of the tools. After all, it is up to the people who look at these reports and what they want to see.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants