Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDI periodic: build and publish multi-arch images and manifest #3909

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

zhlhahaha
Copy link
Contributor

What this PR does / why we need it:
As the PR for build and publish multi-arch manifest has merged kubevirt/containerized-data-importer#3586
We can start to release multi-arch manifest

Release note:

NONE

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Jan 22, 2025
@zhlhahaha
Copy link
Contributor Author

@zhlhahaha
Copy link
Contributor Author

@brianmcarey can we rehearsal this job?

@zhlhahaha
Copy link
Contributor Author

This is emergency, as it block the build process. I have explain the reason here:
kubevirt/containerized-data-importer#3586 (comment)

@akalenyu
Copy link
Contributor

This is emergency, as it block the build process. I have explain the reason here: kubevirt/containerized-data-importer#3586 (comment)

I have two ways to unblock, let me know which one you prefer:

  • Merging this ASAP
  • Merging the revert and working on this

I am fine with either way you and @nunnatsa choose, meanwhile, I can give an lgtm here
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2025
@zhlhahaha
Copy link
Contributor Author

Revert "Build and publish multi-arch images and manifest (#3586)" kubevirt/containerized-data-importer#3615

Hi @akalenyu ,
Can we rehearsal this job?

@akalenyu
Copy link
Contributor

Revert "Build and publish multi-arch images and manifest (#3586)" kubevirt/containerized-data-importer#3615

Hi @akalenyu , Can we rehearsal this job?

TBH I am not sure how to do that, maybe @brianmcarey can help

@zhlhahaha
Copy link
Contributor Author

TBH I am not sure how to do that, maybe @brianmcarey can help

Usually it can be trigger by input following tags, but I do not have the privileges. Also some jobs do not support rehearsal.
/rehearsal-periodic-containerized-data-importer-push-nightly

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 25, 2025
@kubevirt-bot kubevirt-bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 26, 2025
@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2025
@awels
Copy link
Member

awels commented Jan 27, 2025

/rehearse

@kubevirt-bot
Copy link
Contributor

Rehearsal jobs created for this PR:


You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

@awels
Copy link
Member

awels commented Jan 27, 2025

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2025
Copy link
Member

@brianmcarey brianmcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH I am not sure how to do that, maybe @brianmcarey can help

Usually it can be trigger by input following tags, but I do not have the privileges. Also some jobs do not support rehearsal. /rehearsal-periodic-containerized-data-importer-push-nightly

Rehearsals can't be triggered against periodics - lets just see how the periodic goes itself.

thanks @zhlhahaha

/lgtm

@kubevirt-bot kubevirt-bot merged commit 8337408 into kubevirt:main Jan 27, 2025
5 checks passed
@kubevirt-bot
Copy link
Contributor

@zhlhahaha: Updated the job-config configmap in namespace kubevirt-prow at cluster default using the following files:

  • key containerized-data-importer-periodics.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/containerized-data-importer/containerized-data-importer-periodics.yaml

In response to this:

What this PR does / why we need it:
As the PR for build and publish multi-arch manifest has merged kubevirt/containerized-data-importer#3586
We can start to release multi-arch manifest

Release note:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@zhlhahaha
Copy link
Contributor Author

Multi-arch image is built successfully
https://quay.io/repository/kubevirt/cdi-operator?tab=tags&tag=latest

@Davo911
Copy link
Contributor

Davo911 commented Jan 28, 2025

Thanks @zhlhahaha !

@cfilleke
Copy link
Member

Awesome. Thanks @zhlhahaha !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants