add an optional presubmit e2e test on ARM64#1667
Conversation
Signed-off-by: Howard Zhang <howard.zhang@arm.com>
kubevirt-bot
added
the
dco-signoff: yes
rmohr
left a comment
rmohr
left a comment
There was a problem hiding this comment.
/lgtm
/approve
I think on the long run it would be better if we could directly push the images to a cluster registry, to avoid storing images for testing in persistent repos.
| extract_secret 'kubeconfigARM' /kubeconfig | ||
|
|
||
| # login quay.io | ||
| cat "$QUAY_PASSWORD" | docker login --username $(cat "$QUAY_USER") --password-stdin=true quay.io |
There was a problem hiding this comment.
Do we have to think about deleting some images at some point from quay?
There was a problem hiding this comment.
Yes, this is necessary.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rmohr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
@zhlhahaha: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| labels: | ||
| preset-dind-enabled: "true" | ||
| preset-docker-mirror-proxy: "true" | ||
| preset-shared-images: "true" |
There was a problem hiding this comment.
@zhlhahaha maybe we miss some presets or explicit mounts here? The job seems to miss some scripts: https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/6535/pull-kubevirt-e2e-arm64/1448230111747772416
There was a problem hiding this comment.
Sorry, I just saw the message, fix has uploaded #1677
3 participants
Signed-off-by: Howard Zhang howard.zhang@arm.com