fix(virtctl,create): Validate names of disks

[0xFelix]

What this PR does

Validate the names of disks that are derived from the VM's name or specified by the user against RFC 1123 DNS label rules to avoid generating VMs with disk names that will lead to the VM being rejected upon creation.

Before this PR:

virtctl create vm allows to generate VMs with disk names that will lead to rejection of the VM upon creation.

After this PR:

virtctl create vm validates disk names and prevents disk names that will lead to rejection of a VM upon creation.

Fixes #13340

Why we need it and why it was done in this way

The following tradeoffs were made:

The following alternatives were considered:

Links to places where the discussion took place:

Special notes for your reviewer

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

• Design: A design document was considered and is present (link) or not required
• PR: The PR description is expressive enough and will help future contributors
• Code: Write code that humans can understand and Keep it simple
• Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
• Upgrade: Impact of this change on upgrade flows was considered and addressed if required
• Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
• Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
• Community: Announcement to kubevirt-dev was considered

Release note

virtctl create vm validates disk names and prevents disk names that will lead to rejection of a VM upon creation.

[lyarwood]

/lgtm

Excellent, thanks @0xFelix !

[xpivarc]

/approve

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xpivarc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/virtctl/OWNERS [xpivarc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kubevirt-commenter-bot]

Required labels detected, running phase 2 presubmits:
/test pull-kubevirt-e2e-windows2016
/test pull-kubevirt-e2e-kind-1.30-vgpu
/test pull-kubevirt-e2e-kind-sriov
/test pull-kubevirt-e2e-k8s-1.30-ipv6-sig-network
/test pull-kubevirt-e2e-k8s-1.30-sig-network
/test pull-kubevirt-e2e-k8s-1.30-sig-storage
/test pull-kubevirt-e2e-k8s-1.30-sig-compute
/test pull-kubevirt-e2e-k8s-1.30-sig-operator

[0xFelix]

/cherry-pick release-1.4
/cherry-pick release-1.3
/cherry-pick release-1.2

[kubevirt-bot]

@0xFelix: once the present PR merges, I will cherry-pick it on top of release-1.2, release-1.3, release-1.4 in new PRs and assign them to you.

In response to this:

/cherry-pick release-1.4
/cherry-pick release-1.3
/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[kubevirt-bot]

@0xFelix: #13547 failed to apply on top of branch "release-1.4":

Applying: fix(virtctl,create): Validate names of disks
Using index info to reconstruct a base tree...
M	pkg/virtctl/create/vm/BUILD.bazel
M	pkg/virtctl/create/vm/vm.go
M	pkg/virtctl/create/vm/vm_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/virtctl/create/vm/vm_test.go
CONFLICT (content): Merge conflict in pkg/virtctl/create/vm/vm_test.go
Auto-merging pkg/virtctl/create/vm/vm.go
CONFLICT (content): Merge conflict in pkg/virtctl/create/vm/vm.go
Auto-merging pkg/virtctl/create/vm/BUILD.bazel
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 fix(virtctl,create): Validate names of disks

In response to this:

/cherry-pick release-1.4
/cherry-pick release-1.3
/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[kubevirt-bot]

@0xFelix: #13547 failed to apply on top of branch "release-1.3":

Applying: fix(virtctl,create): Validate names of disks
Using index info to reconstruct a base tree...
M	pkg/virtctl/create/vm/BUILD.bazel
M	pkg/virtctl/create/vm/vm.go
M	pkg/virtctl/create/vm/vm_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/virtctl/create/vm/vm_test.go
CONFLICT (content): Merge conflict in pkg/virtctl/create/vm/vm_test.go
Auto-merging pkg/virtctl/create/vm/vm.go
CONFLICT (content): Merge conflict in pkg/virtctl/create/vm/vm.go
Auto-merging pkg/virtctl/create/vm/BUILD.bazel
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 fix(virtctl,create): Validate names of disks

In response to this:

/cherry-pick release-1.4
/cherry-pick release-1.3
/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[kubevirt-bot]

@0xFelix: #13547 failed to apply on top of branch "release-1.2":

Applying: fix(virtctl,create): Validate names of disks
Using index info to reconstruct a base tree...
M	pkg/virtctl/create/vm/BUILD.bazel
M	pkg/virtctl/create/vm/vm.go
M	pkg/virtctl/create/vm/vm_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/virtctl/create/vm/vm_test.go
CONFLICT (content): Merge conflict in pkg/virtctl/create/vm/vm_test.go
Auto-merging pkg/virtctl/create/vm/vm.go
CONFLICT (content): Merge conflict in pkg/virtctl/create/vm/vm.go
Auto-merging pkg/virtctl/create/vm/BUILD.bazel
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 fix(virtctl,create): Validate names of disks

In response to this:

/cherry-pick release-1.4
/cherry-pick release-1.3
/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[kubevirt-bot]

@0xFelix: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubevirt-e2e-kind-1.30-vgpu	e81e0e3	link	unknown	/test pull-kubevirt-e2e-kind-1.30-vgpu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.