This repository has been archived by the owner on Jun 13, 2023. It is now read-only.
quick-workaround: syntax error #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
do-not-merge/release-note-label-needed
sHaggYcaT
changed the title
|
#621 is more correct fix |
|
Looks like #621 still not merged :( Can we merge this patch, then Yan bring correct fix? |
kubevirt-bot
added
release-note-none
ffromani
approved these changes
May 16, 2019
MarSik
reviewed
May 16, 2019
| &expect.BExp{R: resp}, | ||
| }, 60) | ||
| Expect(err).ToNot(HaveOccurred()) | ||
| ktests.WaitUntilVMIReady(vmi, ktests.LoggedInCirrosExpecter) |
|
Yeah, I do not know what is worse.. the original breakage should have never happened. Lets merge this one to unblock our work. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Due syntax error, few our tests now broken. Please approve it fix compilation error issue
Release note: