Internal only: Remove unused field in a helper type in conversion - #4390
Conversation
Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>
kubevirt-prow
Bot
added
release-note-none
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe conversion payload no longer stores Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Warning Review ran into problems🔥 ProblemsLinked repositories: Your configuration references 13 linked repositories, but your current plan allows 10. Analyzed Linked repositories: Public OSS repositories can only analyze public repositories installed in this organization. Analyzed Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
api/v1beta1/conversion_fuzz_test.go (1)
412-412: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueMinor: stray
{in comment is misleading.The comment
//add unknown FG {includes a trailing{that reads like an opening brace but is just comment text. Consider removing it for clarity.✏️ Suggested fix
- if r.IntN(2) == 1 { //add unknown FG { + if r.IntN(2) == 1 { // add unknown FG🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@api/v1beta1/conversion_fuzz_test.go` at line 412, Remove the stray trailing “{” from the inline comment in the r.IntN(2) conditional, leaving the comment text as “add unknown FG”.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@api/v1beta1/conversion_fuzz_test.go`:
- Line 412: Remove the stray trailing “{” from the inline comment in the
r.IntN(2) conditional, leaving the comment text as “add unknown FG”.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: cfe2febc-bfb1-40e4-a25b-7fc459240c1a
📒 Files selected for processing (2)
api/v1beta1/conversion.goapi/v1beta1/conversion_fuzz_test.go
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
kubevirt/hyperconverged-cluster-operator(manual)kubevirt/monitoring(manual)
💤 Files with no reviewable changes (1)
- api/v1beta1/conversion.go
Coverage Report for CI Build 29182124755Coverage decreased (-0.001%) to 81.536%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
* Test that unknown FGs survive the v1 => v1beta1 => v1 round trip conversion. * Randomize the alpha and beta FGs, instead of using hardcode names, so when the hardcoded FG will be graduated or removed, the test will still be effective. Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>
8b6977c to
85d4fae
Compare
|
|
hco-e2e-upgrade-prev-operator-sdk-azure lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-aws, ci/prow/hco-e2e-operator-sdk-gcp, ci/prow/hco-e2e-operator-sdk-sno-aws, ci/prow/hco-e2e-upgrade-operator-sdk-aws, ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws, ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws, ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-aws DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
hco-e2e-consecutive-operator-sdk-upgrades-azure lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-aws DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@nunnatsa: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
hco-e2e-upgrade-operator-sdk-sno-azure lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avlitman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-prow
Bot
added
the
approved
|
/lgtm |
4 participants
What this PR does / why we need it:
Remove the unused
DisableMDevConfigurationFGfield from thev1OnlyFieldstype, in the API conversion logic.Also, improve api conversion fuzz test
Release note: