Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release 1.14] Fix the publish github action #3324

Merged

Conversation

nunnatsa
Copy link
Collaborator

@nunnatsa nunnatsa commented Mar 3, 2025

What this PR does / why we need it:
The "Publish Tagged Version to Community Operators" github action fails because when setting up golang, we want to use golang version from the the go.mod file, but this is checked out only in the next step.

Fix by replacing the order of the step, so we first checking out the code and only then setting up golang.

Release note:

None

The "Publish Tagged Version to Community Operators" github action fails
because when setting up golang, we want to use golang version from the
the go.mod file, but this is checked out only in the next step.

Fix by replacing the order of the step, so we first checking out the
code and only then setting up golang.

Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS labels Mar 3, 2025
Copy link

sonarqubecloud bot commented Mar 3, 2025

Copy link
Collaborator

@orenc1 orenc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2025
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: orenc1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2025
@kubevirt-bot kubevirt-bot merged commit 27d192f into kubevirt:release-1.14 Mar 3, 2025
10 checks passed
@nunnatsa nunnatsa deleted the r114-fix-publish-community branch March 3, 2025 14:50
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 13632494928

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.724%

Totals Coverage Status
Change from base Build 13631852342: 0.0%
Covered Lines: 6245
Relevant Lines: 8707

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants