Skip to content

[release-v0.13] Allow dynamic linking of binaries#213

Merged
kubevirt-bot merged 2 commits intokubevirt:release-v0.13from
kubevirt-bot:cherry-pick-205-to-release-v0.13
Jun 20, 2023
Merged

[release-v0.13] Allow dynamic linking of binaries#213
kubevirt-bot merged 2 commits intokubevirt:release-v0.13from
kubevirt-bot:cherry-pick-205-to-release-v0.13

Conversation

@kubevirt-bot
Copy link
Copy Markdown

This is an automated cherry-pick of #205

/assign awels

NONE

awels added 2 commits June 16, 2023 14:22
The release was creating statically linked binaries
and there is no particular reason for this. Doing
dynamically linked binaries would decrase the container
size.

Signed-off-by: Alexander Wels <awels@redhat.com>
…he Dockerfile so the binaries can run Fixed failing functional test that was not calculating the size properly from the `df -Bk` command. It was calculating from 1000 instead of 1024 and the size was wrong because of it.

Signed-off-by: Alexander Wels <awels@redhat.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jun 16, 2023
@kubevirt-bot kubevirt-bot requested review from aglitke and mhenriks June 16, 2023 14:22
@awels
Copy link
Copy Markdown
Member

awels commented Jun 16, 2023

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2023
@kubevirt-bot
Copy link
Copy Markdown
Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2023
@awels
Copy link
Copy Markdown
Member

awels commented Jun 16, 2023

/retest-required

1 similar comment
@awels
Copy link
Copy Markdown
Member

awels commented Jun 16, 2023

/retest-required

@awels
Copy link
Copy Markdown
Member

awels commented Jun 20, 2023

/override pull-hostpath-provisioner-k8s-e2e-storage

@kubevirt-bot
Copy link
Copy Markdown
Author

@awels: Overrode contexts on behalf of awels: pull-hostpath-provisioner-k8s-e2e-storage

Details

In response to this:

/override pull-hostpath-provisioner-k8s-e2e-storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot merged commit a24c92f into kubevirt:release-v0.13 Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants